[ZEPPELIN-6506] Return empty list instead of null from completion() in Groovy interpreter#5287
Open
miinhho wants to merge 1 commit into
Open
[ZEPPELIN-6506] Return empty list instead of null from completion() in Groovy interpreter#5287miinhho wants to merge 1 commit into
miinhho wants to merge 1 commit into
Conversation
…n Groovy interpreter
Contributor
|
LGTM :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix
GroovyInterpreter.completion()to return an empty list instead of null when autocomplete is not supported. This aligns with the collection-returning method contract (Effective Java Item 54), avoids potential NullPointerExceptions in the completion call chain, and provides a safer API for programmatic use.What type of PR is it?
Bug Fix
Todos
GroovyInterpreter.completion()to return an empty list instead of nullWhat is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
N/A
Questions: